Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #72 check is iterator an array correctly #73

Closed
wants to merge 1 commit into from
Closed

fix #72 check is iterator an array correctly #73

wants to merge 1 commit into from

Conversation

rdeangelis83
Copy link

@rdeangelis83 rdeangelis83 commented Sep 22, 2021

fix #72

@ysmood
Copy link
Owner

ysmood commented Oct 11, 2021

Have you run the unit tests on your local?

@rdeangelis83
Copy link
Author

@ysmood no, sorry for that. Are you facing some issues in the unit tests?

@ysmood
Copy link
Owner

ysmood commented Oct 23, 2021

Yes, it will fail the tests. At least the coverage test will fail.

@rdeangelis83 rdeangelis83 closed this by deleting the head repository Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promise.all and Promise.allSettled doesn't work if the promise array has been created in a different frame.
2 participants